Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the netApp model obtaining error #870

Merged
merged 11 commits into from
May 20, 2022

Conversation

guankc
Copy link
Contributor

@guankc guankc commented Apr 8, 2022

Fix the netApp model obtaining error
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #870 (9e0f778) into master (00a5d58) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
- Coverage   71.37%   71.33%   -0.04%     
==========================================
  Files         182      182              
  Lines       21127    21133       +6     
  Branches     3224     3226       +2     
==========================================
- Hits        15079    15076       -3     
- Misses       5033     5037       +4     
- Partials     1015     1020       +5     
Impacted Files Coverage Δ
delfin/drivers/netapp/dataontap/netapp_handler.py 64.00% <50.00%> (-0.11%) ⬇️
delfin/drivers/fake_storage/__init__.py 93.63% <0.00%> (-1.53%) ⬇️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit c9c842c into sodafoundation:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants