Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #873 #878

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Conversation

UtkarshShah0
Copy link
Contributor

Fixed the return value in the function get_remote_file_to_xml

What this PR does / why we need it:
Fixed the return value in the function get_remote_file_to_xml

Which issue this PR fixes:
fixes #873

Special notes for your reviewer:
SODACODE 2022

Fixed the return value in the function get_remote_file_to_xml
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #878 (f0fb5f1) into master (72b8000) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #878   +/-   ##
=======================================
  Coverage   70.58%   70.58%           
=======================================
  Files         180      180           
  Lines       18825    18825           
  Branches     2769     2769           
=======================================
  Hits        13288    13288           
  Misses       4694     4694           
  Partials      843      843           
Impacted Files Coverage Δ
delfin/drivers/utils/tools.py 70.70% <0.00%> (ø)

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v added SODACODE2022 SODACODE2022 Hackathon Label SODALOW SODACODE2022 Hackathon Priority Label labels Apr 22, 2022
@skdwriting skdwriting merged commit ff518bc into sodafoundation:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SODACODE2022 SODACODE2022 Hackathon Label SODALOW SODACODE2022 Hackathon Priority Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return statement is present inside the finally block
3 participants