Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed inappropriate operator (And) #872 #879

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

code4Y
Copy link
Contributor

@code4Y code4Y commented Apr 21, 2022

What this PR does / why we need it:
Removes inappropriate 'And' operator and duplicate 'host'.

Which issue this PR fixes:
fixes #872

Special notes for your reviewer:
Thank you! SODACODE2022

And operator and duplicate host was removed
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #879 (d3f92d1) into master (72babd7) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #879      +/-   ##
==========================================
- Coverage   70.59%   70.58%   -0.01%     
==========================================
  Files         180      180              
  Lines       18825    18825              
  Branches     2769     2769              
==========================================
- Hits        13289    13288       -1     
  Misses       4694     4694              
- Partials      842      843       +1     
Impacted Files Coverage Δ
delfin/test.py 59.69% <0.00%> (ø)
delfin/drivers/fake_storage/__init__.py 94.40% <0.00%> (-0.26%) ⬇️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvithks
Copy link
Member

@sushanthakumar Can you PTAL

Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v added SODACODE2022 SODACODE2022 Hackathon Label SODALOW SODACODE2022 Hackathon Priority Label labels Apr 22, 2022
@skdwriting skdwriting merged commit 72b8000 into sodafoundation:master Apr 22, 2022
@code4Y code4Y deleted the fix_host_and_in_test branch April 22, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SODACODE2022 SODACODE2022 Hackathon Label SODALOW SODACODE2022 Hackathon Priority Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the delfin/test.py the start_service function body has inappropriate operation
4 participants