Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated_post_install_verification #882

Merged

Conversation

UtkarshShah0
Copy link
Contributor

Fixed issue #840
Added post install verification step

What this PR does / why we need it:
Added post install verification step in installer readme file

Which issue this PR fixes :
fixes #840

Special notes for your reviewer:
SODACODE2022 thanks

Fixed issue sodafoundation#840 
Added post install verification step
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #882 (66ff112) into master (ff518bc) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
- Coverage   70.60%   70.58%   -0.02%     
==========================================
  Files         180      180              
  Lines       18825    18825              
  Branches     2769     2769              
==========================================
- Hits        13291    13288       -3     
- Misses       4693     4694       +1     
- Partials      841      843       +2     
Impacted Files Coverage Δ
delfin/drivers/fake_storage/__init__.py 94.40% <0.00%> (-0.77%) ⬇️

@joseph-v joseph-v added SODACODE2022 SODACODE2022 Hackathon Label SODALOW SODACODE2022 Hackathon Priority Label labels Apr 22, 2022
Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sushanthakumar
Copy link
Collaborator

LGTM

@sushanthakumar sushanthakumar merged commit 795934f into sodafoundation:master Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SODACODE2022 SODACODE2022 Hackathon Label SODALOW SODACODE2022 Hackathon Priority Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add post installer steps to local installer
4 participants