Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update in this swagger.yaml #897

Merged
merged 2 commits into from
May 2, 2022
Merged

update in this swagger.yaml #897

merged 2 commits into from
May 2, 2022

Conversation

muniraj321
Copy link
Contributor

update name and description in this file should be disk-> get/v1/disks
GET v1/disks is showing "ports" instead of "disks"
and also in description it was showing ports
2

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

update name and description in this file should be disk-> get/v1/disks
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #897 (a75f3a6) into master (2e116e9) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #897      +/-   ##
==========================================
+ Coverage   70.47%   70.49%   +0.01%     
==========================================
  Files         181      181              
  Lines       19055    19055              
  Branches     2812     2812              
==========================================
+ Hits        13429    13432       +3     
+ Misses       4756     4755       -1     
+ Partials      870      868       -2     
Impacted Files Coverage Δ
delfin/drivers/fake_storage/__init__.py 94.40% <0.00%> (+0.76%) ⬆️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v added SODACODE2022 SODACODE2022 Hackathon Label SODALOW SODACODE2022 Hackathon Priority Label labels Apr 29, 2022
@sushanthakumar
Copy link
Collaborator

LGTM

@joseph-v
Copy link
Collaborator

joseph-v commented May 2, 2022

#SODA-PR-ACCEPTED

@sushanthakumar sushanthakumar merged commit 0272eed into sodafoundation:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SODACODE2022 SODACODE2022 Hackathon Label SODALOW SODACODE2022 Hackathon Priority Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants