Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CM support for VMAX Driver #900

Merged
merged 3 commits into from
May 20, 2022

Conversation

joseph-v
Copy link
Collaborator

What this PR does / why we need it:
Add CM support for VMAX Driver

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #900 (e0e621f) into master (7953bc8) will increase coverage by 0.02%.
The diff coverage is 71.69%.

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
+ Coverage   71.31%   71.34%   +0.02%     
==========================================
  Files         182      182              
  Lines       21237    21240       +3     
  Branches     3243     3241       -2     
==========================================
+ Hits        15146    15153       +7     
+ Misses       5064     5060       -4     
  Partials     1027     1027              
Impacted Files Coverage Δ
...drivers/dell_emc/vmax/alert_handler/snmp_alerts.py 90.47% <50.00%> (-2.03%) ⬇️
delfin/drivers/dell_emc/vmax/client.py 81.72% <64.51%> (+2.08%) ⬆️
delfin/drivers/dell_emc/vmax/vmax.py 83.33% <85.00%> (ø)
delfin/drivers/fake_storage/__init__.py 93.63% <0.00%> (-0.77%) ⬇️

@joseph-v joseph-v changed the title WIP: Add CM support for VMAX Driver Add CM support for VMAX Driver May 19, 2022
Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skdwriting skdwriting merged commit a44794d into sodafoundation:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants