Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix about alarm mangement and refactor some classes and constants. #912

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

littlehotcx
Copy link
Contributor

What this PR does / why we need it:

  1. Bug fix about alarm management.
  2. Refactor some classes and constants.
    Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@littlehotcx littlehotcx force-pushed the chenxicqu_dev_20221030 branch 4 times, most recently from fc088d1 to 9196573 Compare June 27, 2022 15:14
2. Refactor some classes and constants.
@littlehotcx littlehotcx force-pushed the chenxicqu_dev_20221030 branch from 9196573 to 094780d Compare June 27, 2022 15:33
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #912 (8e4d0f5) into master (1422a00) will increase coverage by 0.00%.
The diff coverage is 82.16%.

@@           Coverage Diff           @@
##           master     #912   +/-   ##
=======================================
  Coverage   71.12%   71.13%           
=======================================
  Files         182      182           
  Lines       21889    21899   +10     
  Branches     3346     3340    -6     
=======================================
+ Hits        15568    15577    +9     
+ Misses       5268     5266    -2     
- Partials     1053     1056    +3     
Impacted Files Coverage Δ
delfin/api/v1/storages.py 75.62% <0.00%> (ø)
delfin/drivers/utils/rest_client.py 39.43% <0.00%> (+0.54%) ⬆️
delfin/alert_manager/trap_receiver.py 72.89% <67.30%> (-3.58%) ⬇️
delfin/alert_manager/snmp_validator.py 76.31% <82.60%> (-1.81%) ⬇️
delfin/task_manager/tasks/resources.py 87.80% <93.75%> (+1.96%) ⬆️
delfin/alert_manager/alert_processor.py 67.74% <100.00%> (ø)
delfin/common/constants.py 100.00% <100.00%> (ø)
delfin/task_manager/tasks/alerts.py 92.68% <100.00%> (ø)
delfin/drivers/fake_storage/__init__.py 95.17% <0.00%> (+0.76%) ⬆️
... and 1 more

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v merged commit e723f5d into sodafoundation:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants