Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svc change disk status #932

Merged
merged 3 commits into from
Oct 28, 2022
Merged

svc change disk status #932

merged 3 commits into from
Oct 28, 2022

Conversation

tanjiangyu-ghca
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #932 (25cb65a) into master (f5b25eb) will increase coverage by 0.01%.
The diff coverage is 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
+ Coverage   71.49%   71.51%   +0.01%     
==========================================
  Files         181      181              
  Lines       21921    21925       +4     
  Branches     3332     3333       +1     
==========================================
+ Hits        15672    15679       +7     
+ Misses       5176     5175       -1     
+ Partials     1073     1071       -2     
Impacted Files Coverage Δ
delfin/drivers/ibm/storwize_svc/ssh_handler.py 74.43% <80.00%> (+0.13%) ⬆️
delfin/drivers/fake_storage/__init__.py 94.41% <0.00%> (+0.76%) ⬆️

@tanjiangyu-ghca tanjiangyu-ghca changed the title svc do some optimize svc change disk status Oct 28, 2022
Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit 996ff13 into sodafoundation:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants