Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpu_count for controller model. #938

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

JiuyunZhao
Copy link
Contributor

What this PR does / why we need it:
In some scenarios, we need cpu count to calculate the license of storage device.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #938 (2c20b39) into master (ef43193) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   71.40%   71.50%   +0.09%     
==========================================
  Files         181      181              
  Lines       21925    21926       +1     
  Branches     3333     3333              
==========================================
+ Hits        15656    15678      +22     
+ Misses       5194     5177      -17     
+ Partials     1075     1071       -4     
Impacted Files Coverage Δ
delfin/db/sqlalchemy/models.py 99.66% <100.00%> (+<0.01%) ⬆️
delfin/db/sqlalchemy/api.py 72.04% <0.00%> (+0.38%) ⬆️
delfin/drivers/fake_storage/__init__.py 94.41% <0.00%> (+3.80%) ⬆️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit fc1b485 into sodafoundation:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants