Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup.py for dellemc scaleio #944

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

joseph-v
Copy link
Collaborator

What this PR does / why we need it:
Fix setup.py for dellemc scaleio
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #944 (3ce4591) into master (2874260) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #944      +/-   ##
==========================================
- Coverage   71.37%   71.36%   -0.01%     
==========================================
  Files         187      187              
  Lines       23067    23067              
  Branches     3508     3508              
==========================================
- Hits        16463    16462       -1     
  Misses       5490     5490              
- Partials     1114     1115       +1     
Impacted Files Coverage Δ
delfin/drivers/fake_storage/__init__.py 95.17% <0.00%> (-0.26%) ⬇️

@JiuyunZhao
Copy link
Contributor

LGTM

Copy link
Collaborator

@sushanthakumar sushanthakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skdwriting skdwriting merged commit 9ad2996 into sodafoundation:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants