Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svc 3par vnx controller add cpu count #960

Merged
merged 9 commits into from
Dec 19, 2022

Conversation

amanr032
Copy link

@amanr032 amanr032 commented Dec 16, 2022

What this PR does / why we need it:
This PR adds additional field, cpu_count to supported drivers

Which issue this PR fixes(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)*: fixes #

The PR #940 not permitting rebase. This PR is to rebase and merge #940 using same commits. When this PR gets merged, the PR #940 will be closed

Special notes for your reviewer:

Release note:

@amanr032 amanr032 changed the title Rebase940 svc 3par vnx controller add cpu count Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #960 (03d94dc) into master (f2553bd) will decrease coverage by 0.01%.
The diff coverage is 68.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #960      +/-   ##
==========================================
- Coverage   70.56%   70.54%   -0.02%     
==========================================
  Files         192      192              
  Lines       23205    23217      +12     
  Branches     3568     3570       +2     
==========================================
+ Hits        16374    16378       +4     
- Misses       5712     5716       +4     
- Partials     1119     1123       +4     
Impacted Files Coverage Δ
delfin/drivers/fujitsu/eternus/eternus_stor.py 88.81% <ø> (ø)
delfin/drivers/hpe/hpe_3par/ssh_handler.py 78.74% <54.54%> (-1.26%) ⬇️
...rivers/dell_emc/vnx/vnx_block/component_handler.py 64.08% <66.66%> (+0.01%) ⬆️
delfin/drivers/hpe/hpe_msa/ssh_handler.py 66.79% <66.66%> (-0.01%) ⬇️
delfin/drivers/hpe/hpe_3par/component_handler.py 74.50% <100.00%> (+0.12%) ⬆️
delfin/drivers/hpe/hpe_3par/consts.py 100.00% <100.00%> (ø)
delfin/drivers/ibm/storwize_svc/ssh_handler.py 74.15% <100.00%> (+0.03%) ⬆️
delfin/drivers/fake_storage/__init__.py 94.05% <0.00%> (-0.26%) ⬇️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skdwriting
Copy link
Collaborator

Please add proper PR description and information before merging it. @amanr032 @joseph-v

Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skdwriting skdwriting merged commit 9e7404e into sodafoundation:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants