Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker installation fix #962

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Docker installation fix #962

merged 1 commit into from
Dec 19, 2022

Conversation

amanr032
Copy link

What type of PR is this?
bug fix

What this PR does / why we need it:
Fix for docker installation
Which issue(s) this PR fixes:
Fixes

Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

Test Report:

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #962 (14951f5) into master (9e7404e) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
- Coverage   70.55%   70.53%   -0.02%     
==========================================
  Files         192      192              
  Lines       23217    23217              
  Branches     3570     3570              
==========================================
- Hits        16380    16376       -4     
- Misses       5716     5717       +1     
- Partials     1121     1124       +3     
Impacted Files Coverage Δ
delfin/drivers/fake_storage/__init__.py 93.54% <0.00%> (-1.04%) ⬇️

Copy link
Collaborator

@sushanthakumar sushanthakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v merged commit 7e44e32 into sodafoundation:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants