Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setuptools version to 65.0.0 #978

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

joseph-v
Copy link
Collaborator

@joseph-v joseph-v commented Feb 6, 2023

What this PR does / why we need it:
Latest version of SQLAlchemy module is giving error message

ERROR: launchpadlib 1.10.13 requires testresources, which is not installed.

sqlalchemy failed sqlalchemy.exc.ArgumentError: autocommit=True is no longer supported

This PR will Keep SQLAlchemy version to older one.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #977

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #978 (a5cb63b) into master (e0290fd) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
- Coverage   70.85%   70.78%   -0.08%     
==========================================
  Files         195      195              
  Lines       23987    23987              
  Branches     3674     3674              
==========================================
- Hits        16997    16980      -17     
- Misses       5826     5842      +16     
- Partials     1164     1165       +1     
Impacted Files Coverage Δ
delfin/drivers/fake_storage/__init__.py 90.69% <0.00%> (-2.85%) ⬇️
delfin/db/sqlalchemy/api.py 71.23% <0.00%> (-0.40%) ⬇️

Copy link
Collaborator

@sushanthakumar sushanthakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skdwriting skdwriting merged commit f2765e1 into sodafoundation:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delfin GET/POST storage API calls fail because of latest SQLAlchemy
3 participants