Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed git checkout command in README (Issue #512) #513

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

Mys7erio
Copy link
Contributor

@Mys7erio Mys7erio commented Mar 3, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design

kind documentation

/kind enhancement

What this PR does / why we need it:
This PR fixes a command in the README file. Read issue #512 for more information.

Which issue(s) this PR fixes:

Fixes two issues mentioned in #512:
- Moved "cd installer/ansible" above the "git checkout"
- Corrected version tag of git checkout command

Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

N/A

Test Report:

Special notes for your reviewer:
Hi, I'm a first time contributer to Sodafoundation. I'm opening this PR to fix a small bug in the README file. Kindly accept this pull request and feel free to suggest changes, if need be.

Copy link
Contributor

@josephjacobmorris josephjacobmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the other items also mentioned in the issue and attach a snapshot showing successful installation following the updated doc

@Mys7erio
Copy link
Contributor Author

I pushed the changes requested above. Let me know if anymore changes need to be done.

README.md Show resolved Hide resolved
Copy link
Contributor

@josephjacobmorris josephjacobmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, missing test report

Copy link
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @Mys7erio and congrats for your first PR here! 🚀

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v merged commit bebdf88 into sodafoundation:master Mar 14, 2023
@Mys7erio
Copy link
Contributor Author

Thanks for the greeting @anvithks. Looking forward to making more contributions in the future✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants