-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed git checkout command in README (Issue #512) #513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the other items also mentioned in the issue and attach a snapshot showing successful installation following the updated doc
I pushed the changes requested above. Let me know if anymore changes need to be done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, missing test report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @Mys7erio and congrats for your first PR here! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the greeting @anvithks. Looking forward to making more contributions in the future✌️ |
What type of PR is this?
kind documentation
What this PR does / why we need it:
This PR fixes a command in the README file. Read issue #512 for more information.
Which issue(s) this PR fixes:
Fixes two issues mentioned in #512:
- Moved "cd installer/ansible" above the "git checkout"
- Corrected version tag of git checkout command
Test Report Added?:
N/A
Test Report:
Special notes for your reviewer:
Hi, I'm a first time contributer to Sodafoundation. I'm opening this PR to fix a small bug in the README file. Kindly accept this pull request and feel free to suggest changes, if need be.