Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger file update for multi-cloud #1320

Merged
merged 3 commits into from
Dec 31, 2021

Conversation

PravinRanjan10
Copy link
Collaborator

@PravinRanjan10 PravinRanjan10 commented Dec 27, 2021

This PR is a swagger update for a multi-cloud project
It has improved/correction of some multi-cloud API requests and responses

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

Test Report:

  1. Create Backend

Aws

  1. List All Backend

List All Backend

  1. List Backend

List Backend

  1. List All Type

List all Type

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #1320 (d01696c) into master (dd8b566) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1320   +/-   ##
=======================================
  Coverage   48.12%   48.12%           
=======================================
  Files          10       10           
  Lines        1571     1571           
=======================================
  Hits          756      756           
  Misses        756      756           
  Partials       59       59           

@PravinRanjan10 PravinRanjan10 changed the title Swagger file update of multi-cloud Swagger file update for multi-cloud Dec 27, 2021
type: object
properties:
name:
description: The backend type name.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: The backend type name.
description: The backend type.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

type: object
properties:
name:
description: The backend type name.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar here

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvithks anvithks merged commit 4186845 into sodafoundation:master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants