Change consecutive parameter in unique_key to bool #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vankesteren
approved these changes
Feb 1, 2024
| @@ -146,8 +146,8 @@ def _fit(cls, values): | |||
| lower = values.min() | |||
| high = values.max() + 1 | |||
| if len(values) == high-lower and np.all(values.to_numpy() == np.arange(lower, high)): | |||
There was a problem hiding this comment.
Maybe this comparison is slightly inefficient?
There was a problem hiding this comment.
How would you prefer to do it?
There was a problem hiding this comment.
not sure, in R I'd do all(diff(values) == 1) then we don't need to instantiate a completely new vector which might be a million values. But it's a super small comment which you could ignore as well
There was a problem hiding this comment.
I don't actually know if np.arange will instantiate a new vector. Let's for now keep it like it is. I don't think this will really ever be a bottleneck, and if so we can revise then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237