Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add creation settings #272

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Add creation settings #272

merged 7 commits into from
Mar 19, 2024

Conversation

qubixes
Copy link
Member

@qubixes qubixes commented Mar 5, 2024

Fixes #258

This PR tries to add some more information about how the variable was created. It probably needs a little bit more testing.

@qubixes qubixes requested a review from vankesteren March 5, 2024 16:04
Copy link
Collaborator

@Samuwhale Samuwhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@vankesteren vankesteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the logic looks done! One question: does "creation settings" still cover the meaning? Would "fit parameters", fitting config, estimation settings be better?

@qubixes
Copy link
Member Author

qubixes commented Mar 15, 2024

Looks good, the logic looks done! One question: does "creation settings" still cover the meaning? Would "fit parameters", fitting config, estimation settings be better?

I think those are okay as well. However, I think the point is that some distributions are not estimated / fitted, but simply defined. If you have a suggestion that also covers that use case, then that might be better than creation_settings.

@vankesteren
Copy link
Member

vankesteren commented Mar 19, 2024

After thinking more, I'd go for either:

  • fit_method
  • creation_method

I still think "fit" works, as the user is also "fitting", just not doing ML estimation

You can choose and merge!!

@qubixes
Copy link
Member Author

qubixes commented Mar 19, 2024

After thinking more, I'd go for either:

* fit_method

* creation_method

I still think "fit" works, as the user is also "fitting", just not doing ML estimation

You can choose and merge!!

Okay, creation_method it is then!

@qubixes qubixes merged commit dd3de9c into main Mar 19, 2024
7 checks passed
@qubixes qubixes deleted the add-creation-settings branch March 19, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add provenance information for each variable, including privacy parameters
3 participants