-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add creation settings #272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
679d365
to
0e11e22
Compare
0e11e22
to
cf46445
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the logic looks done! One question: does "creation settings" still cover the meaning? Would "fit parameters", fitting config, estimation settings be better?
I think those are okay as well. However, I think the point is that some distributions are not estimated / fitted, but simply defined. If you have a suggestion that also covers that use case, then that might be better than creation_settings. |
After thinking more, I'd go for either:
I still think "fit" works, as the user is also "fitting", just not doing ML estimation You can choose and merge!! |
Okay, creation_method it is then! |
Fixes #258
This PR tries to add some more information about how the variable was created. It probably needs a little bit more testing.