Revarspec #275
Merged
Revarspec #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix bug where warning wasn't generated anymore.
qubixes
requested review from
Samuwhale and
vankesteren
and removed request for
Samuwhale
vankesteren
reviewed
Mar 8, 2024
| @@ -226,7 +226,7 @@ | |||
| { | |||
| "name": "Embarked", | |||
| "type": "categorical", | |||
| "dtype": "Categorical", | |||
| "dtype": "Categorical(ordering='physical')", | |||
There was a problem hiding this comment.
hmm, this is new from polars.
metasyn/config.py
Outdated
| var_configs: Union[list[dict], list[VarConfig]], | ||
| dist_providers: Union[DistributionProviderList, list[str], str], | ||
| privacy: Union[BasePrivacy, dict], | ||
| var_configs: Union[list[dict], list[VarSpec]], |
There was a problem hiding this comment.
Suggested change
| var_configs: Union[list[dict], list[VarSpec]], | |
| var_specs: Union[list[dict], list[VarSpec]], |
slight suggestion: refactor this arg name
Comment on lines
+101
to
+113
| # Parse the var_specs into a MetaConfig instance. | ||
| if isinstance(var_specs, (pathlib.Path, str)): | ||
| meta_config = MetaConfig.from_toml(var_specs) | ||
| elif isinstance(var_specs, MetaConfig): | ||
| meta_config = var_specs | ||
| elif var_specs is None: | ||
| meta_config = MetaConfig([], dist_providers, privacy) | ||
| else: | ||
| assert privacy is None | ||
| meta_config = MetaConfig(var_specs, dist_providers, privacy) | ||
| if dist_providers is not None: | ||
| meta_config.dist_providers = dist_providers # type: ignore | ||
| if privacy is not None: | ||
| meta_config.privacy = privacy # type: ignore |
There was a problem hiding this comment.
Clear precendence of arguments here, nice
vankesteren
reviewed
Mar 8, 2024
Co-authored-by: Erik-Jan van Kesteren <e.vankesteren1@uu.nl>
Co-authored-by: Erik-Jan van Kesteren <e.vankesteren1@uu.nl>
Co-authored-by: Erik-Jan van Kesteren <e.vankesteren1@uu.nl>
Co-authored-by: Erik-Jan van Kesteren <e.vankesteren1@uu.nl>
qubixes
commented
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #240