Merge pull request #48 from ursais/12-fix-noavatax-cancel

[FIX] Skip Avatax computation if no line has Avatax tax code, for Inv…
sodexis · May 18, 2020 · 1c0dfa6 · 1c0dfa6
2 parents 169bb9f + 23f49ac
commit 1c0dfa6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/avatax_connector/__manifest__.py b/avatax_connector/__manifest__.py
@@ -1,6 +1,6 @@
 {
     "name": "Avalara Avatax Connector",
-    "version": "12.0.2.3.8",
+    "version": "12.0.2.3.9",
     "author": "Fabrice Henrion, Sodexis"
               ", Open Source Integrators",
     "summary": "Sales tax Calculation",

diff --git a/avatax_connector/models/account_invoice.py b/avatax_connector/models/account_invoice.py
@@ -284,7 +284,10 @@ def action_cancel(self):
         account_tax_obj = self.env['account.tax']
         for invoice in self:
             avatax_config = invoice.company_id.get_avatax_config_company()
+            has_avatax_tax = invoice.mapped(
+                'invoice_line_ids.invoice_line_tax_ids.is_avatax')
             if (invoice.type in ['out_invoice', 'out_refund'] and
+                    has_avatax_tax and
                     invoice.partner_id.country_id in avatax_config.country_ids and
                     invoice.state != 'draft'):
                 doc_type = invoice.type == 'out_invoice' and 'SalesInvoice' or 'ReturnInvoice'