Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved FASTA parsing #756

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

valentynbez
Copy link
Contributor

@valentynbez valentynbez commented Sep 22, 2023

Co-authored by: Fabian Kloetzl @kloetzl

Co-authored by: Fabian Kloetzl @kloetzl
@milot-mirdita
Copy link
Member

Thanks you! The change makes sense, however, we have actually modified this part. We check here if a sequence is broken across multiple lines or if its a single line sequence. This enables some different optimizations later in MMseqs2.

@kloetzl
Copy link
Contributor

kloetzl commented Sep 22, 2023

Yeah, the patch needs to be changed accordingly. Shouldn't be too hard to do.

@valentynbez
Copy link
Contributor Author

Sorry, I missed this if statement completely. I see why it passed the regression test.

@milot-mirdita milot-mirdita merged commit 98406dd into soedinglab:master Oct 31, 2023
14 of 15 checks passed
@valentynbez valentynbez deleted the fasta-patch branch January 18, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants