Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HealthCheck passed when ExtensionComponent activate failed #694

Closed
HzjNeverStop opened this issue Aug 24, 2020 · 0 comments · Fixed by #697
Closed

HealthCheck passed when ExtensionComponent activate failed #694

HzjNeverStop opened this issue Aug 24, 2020 · 0 comments · Fixed by #697
Labels
bug Something isn't working
Milestone
3.4.4

Comments

@HzjNeverStop
Copy link
Contributor

the com.alipay.sofa.runtime.ext.component.ExtensionComponent#isHealthy method override super method and ignore the activate result，it result the HealthCheck passed when com.alipay.sofa.service.api.component.Extensible#registerExtension throw exceprion
@sofastack-bot sofastack-bot bot added the question Further information is requested label Aug 24, 2020
@HzjNeverStop HzjNeverStop added bug Something isn't working and removed question Further information is requested labels Aug 24, 2020
@HzjNeverStop HzjNeverStop added this to the 3.4.4 milestone Aug 24, 2020
@HzjNeverStop HzjNeverStop linked a pull request Aug 28, 2020 that will close this issue
Fix extension healthcheck bug #697
Merged
glmapper pushed a commit that referenced this issue Aug 31, 2020
@HzjNeverStop
Fix extension healthcheck bug (#697)
d50d777 
* Fix extension healthcheck bug (#694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.4.4
Development

Successfully merging a pull request may close this issue.

Fix extension healthcheck bug
1 participant
@HzjNeverStop