Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel healthcheck #1052

Merged
merged 23 commits into from
Jan 9, 2023
Merged

Fix parallel healthcheck #1052

merged 23 commits into from
Jan 9, 2023

Conversation

crazysaltfish
Copy link
Contributor

fix parallelHealthcheck timeout bug;
add healthIndicatorStatus to aggregateReadinessHealth()

寻芳 and others added 22 commits August 23, 2022 10:58
add healthIndicatorStatus to aggregateReadinessHealth()
@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes size/L labels Jan 9, 2023
Copy link
Contributor

@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #1052 (df8fb61) into master (93ad0ec) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1052      +/-   ##
============================================
- Coverage     11.25%   11.24%   -0.01%     
  Complexity       41       41              
============================================
  Files           325      325              
  Lines          9312     9320       +8     
  Branches       1275     1280       +5     
============================================
  Hits           1048     1048              
- Misses         8106     8114       +8     
  Partials        158      158              
Impacted Files Coverage Δ
...lipay/sofa/healthcheck/HealthCheckerProcessor.java 0.73% <0.00%> (-0.02%) ⬇️
...pay/sofa/healthcheck/HealthIndicatorProcessor.java 0.00% <0.00%> (ø)
...lipay/sofa/healthcheck/ReadinessCheckListener.java 0.69% <0.00%> (-0.02%) ⬇️
...m/alipay/sofa/boot/constant/SofaBootConstants.java 91.66% <ø> (ø)
...igure/tracer/SofaTracerKafkaAutoConfiguration.java 0.00% <0.00%> (ø)
...re/tracer/SofaTracerRabbitMqAutoConfiguration.java 0.00% <0.00%> (ø)
...re/tracer/SofaTracerRocketMqAutoConfiguration.java 0.00% <0.00%> (ø)
...racer/SofaTracerRestTemplateAutoConfiguration.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit b52393c into sofastack:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants