-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom healthheck and healthindicator config #1129
Merged
HzjNeverStop
merged 28 commits into
sofastack:master
from
crazysaltfish:support_custom_healthheck_and_healthindicator_config
Mar 28, 2023
Merged
Support custom healthheck and healthindicator config #1129
HzjNeverStop
merged 28 commits into
sofastack:master
from
crazysaltfish:support_custom_healthheck_and_healthindicator_config
Mar 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les install failure
…le install failure
…le install failure
…le install failure
Codecov Report
@@ Coverage Diff @@
## master #1129 +/- ##
============================================
- Coverage 11.46% 11.24% -0.23%
Complexity 41 41
============================================
Files 326 324 -2
Lines 9426 9473 +47
Branches 1290 1298 +8
============================================
- Hits 1081 1065 -16
- Misses 8184 8247 +63
Partials 161 161
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
HzjNeverStop
requested changes
Mar 28, 2023
sofa-boot-project/sofa-boot/src/main/java/com/alipay/sofa/boot/health/HealthCheckerConfig.java
Outdated
Show resolved
Hide resolved
HzjNeverStop
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for customizing single healthCheck and healthIndicator