Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix toolkit-common-logging config bug #1178

Conversation

crazysaltfish
Copy link
Contributor

raise SofaConfigSourceSupportListener order to "LoggingApplicationListener.DEFAULT_ORDER - 10" to fix toolkit-common-logging config bug

…tener.DEFAULT_ORDER - 10" to fix toolkit-common-logging config bug
@sofastack-cla sofastack-cla bot added bug Something isn't working cla:yes size/XS labels May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #1178 (e344457) into master (123b3eb) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1178      +/-   ##
============================================
+ Coverage     71.64%   71.68%   +0.04%     
- Complexity     1824     1827       +3     
============================================
  Files           252      252              
  Lines          7349     7349              
  Branches        930      930              
============================================
+ Hits           5265     5268       +3     
  Misses         1605     1605              
+ Partials        479      476       -3     
Impacted Files Coverage Δ
.../boot/logging/LogEnvironmentPreparingListener.java 93.93% <100.00%> (ø)
...boot/listener/SofaConfigSourceSupportListener.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazysaltfish crazysaltfish merged commit 74a991d into sofastack:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants