Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compatibility #1221

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Conversation

HzjNeverStop
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1221 (49bdd2d) into 3.x (312cd32) will increase coverage by 0.01%.
Report is 2 commits behind head on 3.x.
The diff coverage is 84.61%.

@@             Coverage Diff              @@
##                3.x    #1221      +/-   ##
============================================
+ Coverage     71.63%   71.64%   +0.01%     
- Complexity     1833     1855      +22     
============================================
  Files           254      260       +6     
  Lines          7371     7462      +91     
  Branches        933      944      +11     
============================================
+ Hits           5280     5346      +66     
- Misses         1611     1636      +25     
  Partials        480      480              
Files Changed Coverage Δ
...ay/sofa/boot/compatibility/VerificationResult.java 69.23% <69.23%> (ø)
...boot/compatibility/AbstractJarVersionVerifier.java 81.81% <81.81%> (ø)
...ility/AbstractSwitchableCompatibilityVerifier.java 81.81% <81.81%> (ø)
...tibilityVerifierApplicationContextInitializer.java 92.30% <92.30%> (ø)
...ot/compatibility/CompatibilityNotMetException.java 100.00% <100.00%> (ø)
.../compatibility/CompositeCompatibilityVerifier.java 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 43ec436 into sofastack:3.x Aug 7, 2023
4 checks passed
HzjNeverStop added a commit to HzjNeverStop/sofa-boot that referenced this pull request Aug 14, 2023
HzjNeverStop added a commit that referenced this pull request Aug 16, 2023
* Support sofa service duplicate configurable (#1204)

* remove SearchStrategy#CURRENT (#1220)

* Support compatibility (#1221)

* update error logs (#1222)

Co-authored-by: 致节 <hzj266771@antgroup.com>

* fix pmd

* fix pmd

* update springboot 3.1.2

* update comsumerHelper

---------

Co-authored-by: Dando <jialindeng7@163.com>
Co-authored-by: 致节 <hzj266771@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants