Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init interface type canonical name to avoid multi reflection #1233

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Init interface type canonical name to avoid multi reflection #1233

merged 3 commits into from
Aug 21, 2023

Conversation

HzjNeverStop
Copy link
Contributor

No description provided.

@HzjNeverStop HzjNeverStop changed the title init interface class canonical name to avoid multi reflection Init interface type canonical name to avoid multi reflection Aug 21, 2023
@HzjNeverStop HzjNeverStop mentioned this pull request Aug 21, 2023
Closed
crazysaltfish
crazysaltfish approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Merging #1233 (44d9280) into 3.x (9c9a0b9) will decrease coverage by 0.17%.
Report is 1 commits behind head on 3.x.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##                3.x    #1233      +/-   ##
============================================
- Coverage     71.83%   71.67%   -0.17%     
+ Complexity     1864     1860       -4     
============================================
  Files           260      261       +1     
  Lines          7470     7473       +3     
  Branches        943      943              
============================================
- Hits           5366     5356      -10     
- Misses         1623     1639      +16     
+ Partials        481      478       -3
Files Changed Coverage Δ
.../com/alipay/sofa/runtime/spi/binding/Contract.java 0.00% <0.00%> (ø)
...a/runtime/invoke/DynamicJvmServiceProxyFinder.java 38.02% <50.00%> (ø)
...fa/runtime/service/component/AbstractContract.java 66.66% <100.00%> (+1.96%) ⬆️

... and 4 files with indirect coverage changes

crazysaltfish
crazysaltfish approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit bccf25f into sofastack:3.x Aug 21, 2023
2 of 4 checks passed
HzjNeverStop added a commit to HzjNeverStop/sofa-boot that referenced this pull request Aug 22, 2023
@HzjNeverStop
Init interface type canonical name to avoid multi reflection (sofasta…
b262b16 
…ck#1233)
HzjNeverStop added a commit to HzjNeverStop/sofa-boot that referenced this pull request Aug 22, 2023
@HzjNeverStop
Init interface type canonical name to avoid multi reflection (sofasta…
436ea79 
…ck#1233)
HzjNeverStop added a commit that referenced this pull request Aug 22, 2023
@HzjNeverStop
Init interface type canonical name to avoid multi reflection (#1233) (#…
254e39d 
…1235)
@yuanChina
Copy link

这个改动没有合并到4.0么

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazysaltfish crazysaltfish crazysaltfish approved these changes

Assignees
No one assigned
Labels
cla:yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HzjNeverStop @yuanChina @crazysaltfish