optimize getBiz method by reduce invoke Map.toArray() (#1286) #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @NTP1996, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
|
请 @HzjNeverStop 帮忙 review 下，看是否 ok。解决 #1286 ，非常感谢。 |
修改方式没有问题，请修改测试用例 DynamicJvmServiceProxyFinderTests 以通过 CI |
已修改 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1287 +/- ##
============================================
+ Coverage 82.95% 82.98% +0.02%
- Complexity 2916 2925 +9
============================================
Files 330 330
Lines 9620 9625 +5
Branches 1164 1164
============================================
+ Hits 7980 7987 +7
Misses 1131 1131
+ Partials 509 507 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用
getBizByClassLoader方法替换getBizInOrder方法。减少 Map.toArray 调用次数，和冗余的排序操作；