Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kubernetes registry configuration #1288

Conversation

wangchengming666
Copy link
Contributor

Support kubernetes registry configuration, related sofastack/sofa-rpc#1395

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (447b919) to head (2c96d27).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1288      +/-   ##
============================================
- Coverage     83.14%   83.09%   -0.05%     
- Complexity     2951     2954       +3     
============================================
  Files           333      335       +2     
  Lines          9669     9679      +10     
  Branches       1168     1168              
============================================
+ Hits           8039     8043       +4     
- Misses         1123     1128       +5     
- Partials        507      508       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

呈铭 added 2 commits February 28, 2024 14:30
# Conflicts:
#	sofa-boot-project/sofa-boot-autoconfigure/src/main/java/com/alipay/sofa/boot/autoconfigure/rpc/RegistryConfigurations.java
#	sofa-boot-project/sofa-boot-core/rpc-sofa-boot/src/main/java/com/alipay/sofa/rpc/boot/config/SofaBootRpcConfigConstants.java
Copy link
Contributor

@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 29637f3 into sofastack:master Mar 25, 2024
3 of 4 checks passed
@wangchengming666 wangchengming666 deleted the support-kubernetes-registry-configuration branch March 25, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants