Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concuren problem in jvmfilterholder #1295

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Fix concuren problem in jvmfilterholder #1295

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43cd56a
add spring-boot-configuration-processor in sofa-boot-actuator-autocon…
Mar 4, 2024
9356703
fix JvmFilterHolder concurrent safe problem
Mar 6, 2024
31c101c
Merge branch 'master' into fix_concuren_problem_in_jvmfilterholder
Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ...-core/runtime-sofa-boot/src/main/java/com/alipay/sofa/runtime/filter/JvmFilterHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@

import org.springframework.core.annotation.AnnotationAwareOrderComparator;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.concurrent.CopyOnWriteArrayList;
import java.util.concurrent.atomic.AtomicBoolean;

/**
Expand All @@ -31,7 +30,7 @@
*/
public class JvmFilterHolder {

private final List<JvmFilter> JVM_FILTERS = new ArrayList<>();
private final List<JvmFilter> JVM_FILTERS = new CopyOnWriteArrayList<>();

private final AtomicBoolean FILTERS_SORTED = new AtomicBoolean(false);

Expand All @@ -56,8 +55,8 @@ public List<JvmFilter> getJvmFilters() {
}

public static boolean beforeInvoking(JvmFilterContext context) {
List<JvmFilter> filters = Collections.unmodifiableList(context.getSofaRuntimeContext()
.getJvmFilterHolder().getJvmFilters());
List<JvmFilter> filters = context.getSofaRuntimeContext().getJvmFilterHolder()
.getJvmFilters();
for (JvmFilter filter : filters) {
if (!filter.before(context)) {
return false;
Expand All @@ -67,8 +66,8 @@ public static boolean beforeInvoking(JvmFilterContext context) {
}

public static boolean afterInvoking(JvmFilterContext context) {
List<JvmFilter> filters = Collections.unmodifiableList(context.getSofaRuntimeContext()
.getJvmFilterHolder().getJvmFilters());
List<JvmFilter> filters = context.getSofaRuntimeContext().getJvmFilterHolder()
.getJvmFilters();
for (int i = filters.size() - 1; i >= 0; --i) {
if (!filters.get(i).after(context)) {
return false;
Expand Down
Loading