-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mac M1(osx-aarch_64) compile and test #1306
Support mac M1(osx-aarch_64) compile and test #1306
Conversation
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Signed-off-by: crazyhzm <crazyhzm@apache.org>
72ccea7
to
526f4e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #1306 +/- ##
============================================
+ Coverage 72.42% 72.44% +0.02%
- Complexity 1989 1991 +2
============================================
Files 270 270
Lines 7840 7840
Branches 1001 1001
============================================
+ Hits 5678 5680 +2
Misses 1650 1650
+ Partials 512 510 -2 ☔ View full report in Codecov by Sentry. |
protoc 3.7.1 don't support osx-aarch_64
https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.7.1/
Minimum supported version is 3.17.3:
https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.17.3/
io.grpc:protoc-gen-grpc-java 1.28.0 don't support osx-aarch_64
https://repo.maven.apache.org/maven2/io/grpc/protoc-gen-grpc-java/1.28.0/
Minimum supported version is 1.42.3:
https://repo.maven.apache.org/maven2/io/grpc/protoc-gen-grpc-java/1.42.3/