Fix lazyinit value transfer problem #1316
Conversation
WalkthroughThe recent update in the SOFA Boot Core project enhances bean initialization in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- sofa-boot-project/sofa-boot-core/runtime-sofa-boot/src/main/java/com/alipay/sofa/runtime/spring/ServiceBeanFactoryPostProcessor.java (2 hunks)
Additional comments not posted (2)
sofa-boot-project/sofa-boot-core/runtime-sofa-boot/src/main/java/com/alipay/sofa/runtime/spring/ServiceBeanFactoryPostProcessor.java (2)
56-56: Added import statement forAbstractBeanDefinition.This import is necessary for the type casting in the modified method
doGenerateSofaReferenceDefinition.
270-272: Conditional logic added to setlazyInitbased on the inputbeanDefinition.The changes correctly implement the intended functionality to ensure that the
lazyInitproperty is transferred appropriately, aligning with the PR objectives.
Signed-off-by: Jermaine Hua <crazyhzm@apache.org>
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- sofa-boot-project/sofa-boot-core/runtime-sofa-boot/src/main/java/com/alipay/sofa/runtime/spring/ServiceBeanFactoryPostProcessor.java (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- sofa-boot-project/sofa-boot-core/runtime-sofa-boot/src/main/java/com/alipay/sofa/runtime/spring/ServiceBeanFactoryPostProcessor.java
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1316 +/- ##
============================================
+ Coverage 83.07% 83.13% +0.06%
- Complexity 2959 2962 +3
============================================
Files 337 337
Lines 9707 9709 +2
Branches 1168 1170 +2
============================================
+ Hits 8064 8072 +8
+ Misses 1132 1127 -5
+ Partials 511 510 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jermaine Hua <crazyhzm@apache.org>
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- sofa-boot-tests/sofa-boot-smoke-tests/sofa-boot-smoke-tests-runtime/src/test/java/com/alipay/sofa/smoke/tests/runtime/spring/SofaBeanLazyInitTests.java (1 hunks)
Additional comments not posted (3)
sofa-boot-tests/sofa-boot-smoke-tests/sofa-boot-smoke-tests-runtime/src/test/java/com/alipay/sofa/smoke/tests/runtime/spring/SofaBeanLazyInitTests.java (3)
49-60: Test methodcheckSofaServiceBeanDefinitionLazyInitAttributecorrectly checks the lazy initialization attribute of the SofaService bean.
62-71: Test methodcheckSofaReferenceBeanDefinitionLazyInitAttributecorrectly checks the lazy initialization attribute of the SofaReference bean.
73-90: Configuration and service implementation classes are correctly defined and used in the test methods.
Summary by CodeRabbit