Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade spring boot version to 3.3.4 #1335

Merged

Conversation

CrazyHZM
Copy link
Contributor

@CrazyHZM CrazyHZM commented Aug 5, 2024

Summary by CodeRabbit

  • New Features
    • Upgraded to Spring Boot version 3.3.4, potentially enhancing application performance and introducing new capabilities.
    • Updated tracer.core dependency to version 4.0.1, which may include bug fixes and improvements.
    • Updated spring.cloud dependency to version 2023.0.3, suggesting minor improvements or bug fixes.
  • Bug Fixes
    • Updated dependencies may resolve existing issues and improve stability in the application functionality.

Signed-off-by: JermaineHua <crazyhzm@apache.org>
Copy link

coderabbitai bot commented Aug 5, 2024

Walkthrough

The recent update in the pom.xml file primarily involves upgrading the Spring Boot dependency version from 3.2.6 to 3.3.4. This change affects both the parent section and the properties section of the file. Additionally, the version of the tracer.core dependency in the sofaboot-dependencies/pom.xml file has been updated from 4.0.0 to 4.0.1, and the spring.cloud.version has been updated from 2023.0.0 to 2023.0.3. These version bumps may introduce new features, bug fixes, or changes in behavior.

Changes

Files Change Summary
pom.xml Updated Spring Boot version from 3.2.6 to 3.3.4 in both <parent> and <properties> sections.
sofa-boot-project/sofaboot-dependencies/pom.xml Updated tracer.core.version from 4.0.0 to 4.0.1 and spring.cloud.version from 2023.0.0 to 2023.0.3.

Possibly related PRs

  • Update Spring Boot 3.2.6 #1326: This PR updates the Spring Boot version from 3.2.5 to 3.2.6, which is directly related to the main PR's update from 3.2.6 to 3.3.4.

Suggested labels

size/S

Suggested reviewers

  • HzjNeverStop

Poem

In fields of code, a rabbit hops,
With Spring Boot's leap, the magic pops!
From 3.2 to 3.3, oh what a flight,
New features await, shining so bright!
Bugs may now flee, like shadows at dawn,
As we code on and the magic goes on! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ec3c43d and 24ea1c1.

📒 Files selected for processing (1)
  • sofa-boot-project/sofaboot-dependencies/pom.xml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • sofa-boot-project/sofaboot-dependencies/pom.xml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1f4e235 and cc27a89.

Files selected for processing (1)
  • pom.xml (2 hunks)
Additional comments not posted (2)
pom.xml (2)

27-27: Spring Boot version update in <parent> section approved.

The Spring Boot version has been correctly updated from 3.2.6 to 3.3.2 in the <parent> section.


40-40: Spring Boot version update in <properties> section approved.

The Spring Boot version has been correctly updated from 3.2.6 to 3.3.2 in the <properties> section.

Signed-off-by: JermaineHua <crazyhzm@apache.org>
@CrazyHZM CrazyHZM changed the title upgrade spring boot version to 3.3.2 upgrade spring boot version to 3.3.4 Sep 23, 2024
Signed-off-by: JermaineHua <crazyhzm@apache.org>
Signed-off-by: JermaineHua <crazyhzm@apache.org>
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.00%. Comparing base (d285ec4) to head (24ea1c1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1335      +/-   ##
============================================
- Coverage     83.01%   83.00%   -0.02%     
+ Complexity     2976     2975       -1     
============================================
  Files           340      340              
  Lines          9831     9831              
  Branches       1177     1177              
============================================
- Hits           8161     8160       -1     
  Misses         1157     1157              
- Partials        513      514       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 8524bee into sofastack:master Sep 26, 2024
5 of 6 checks passed
@CrazyHZM CrazyHZM deleted the feat/upgrade_spring_boot_version_3.3.2 branch September 26, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants