Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback ref and callback classname attribute. #223

Merged
merged 9 commits into from
Sep 27, 2018
Merged

Add callback ref and callback classname attribute. #223

merged 9 commits into from
Sep 27, 2018

Conversation

QilongZhang
Copy link
Contributor

Add callback ref and callback classname attribute.

@QilongZhang QilongZhang added the enhancement New feature or request label Sep 20, 2018
@QilongZhang QilongZhang added this to the 2.5.0 milestone Sep 20, 2018
@coveralls
Copy link

coveralls commented Sep 20, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 523

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.229%
Totals Coverage Status
Change from base Build 522: 0.0%
Covered Lines: 1577
Relevant Lines: 2214
💛 - Coveralls

@QilongZhang QilongZhang mentioned this pull request Sep 21, 2018
Closed
ujjboy
ujjboy requested changes Sep 23, 2018
View reviewed changes
...-boot-starter/src/main/java/com/alipay/sofa/runtime/api/annotation/SofaReferenceBinding.java
* callback implementation class name
*
* @return callback implementation class name
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add @since 2.5.0

...-boot-starter/src/main/java/com/alipay/sofa/runtime/api/annotation/SofaReferenceBinding.java
* callback spring beanName ref
*
* @return callback spring beanName ref
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add @since 2.5.0

@QilongZhang
Copy link
Contributor Author

@ujjboy

@ujjboy ujjboy merged commit 7a60e68 into sofastack:master Sep 27, 2018
@QilongZhang QilongZhang deleted the add_callbak_attribute branch October 30, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjboy ujjboy ujjboy approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QilongZhang @coveralls @ujjboy