Support @SofaService to annotated on method and refactor related code. #288

QilongZhang · 2018-11-24T11:46:11Z

Support @SoafService to annotated on method. Support @SofaService in bean method and @SofaReference in parameter #277
Support @SofaReference to annotated on parameter. Support @SofaService in bean method and @SofaReference in parameter #277
Refactor way of publishing SofaService to fix bug BeanNameAutoProxyCreator not work with @SofaService #276
Refactor way of registering SofaRuntimeContext as a singleton bean to fix bug SofaService can NOT be resolved among multi Bizs which contain Spring Cloud components. #283

codecov · 2018-11-24T11:50:49Z

Codecov Report

Merging #288 into master will increase coverage by 2.64%.
The diff coverage is 79.22%.

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   60.19%   62.83%   +2.64%     
==========================================
  Files          73       77       +4     
  Lines        1781     1975     +194     
  Branches      203      230      +27     
==========================================
+ Hits         1072     1241     +169     
- Misses        557      569      +12     
- Partials      152      165      +13

Impacted Files	Coverage Δ
...ntime/spring/parser/ReferenceDefinitionParser.java	`50% <ø> (ø)`	⬆️
.../com/alipay/sofa/infra/utils/SOFABootEnvUtils.java	`83.33% <ø> (ø)`	⬆️
...pring/parser/AbstractContractDefinitionParser.java	`58.62% <ø> (ø)`	⬆️
...ng/configuration/SofaRuntimeAutoConfiguration.java	`80% <ø> (-14.6%)`	⬇️
...ofa/runtime/spring/factory/ServiceFactoryBean.java	`66.66% <0%> (+8.33%)`	⬆️
...runtime/spring/parser/ServiceDefinitionParser.java	`66.66% <100%> (ø)`	⬆️
...me/spring/factory/AbstractContractFactoryBean.java	`56.75% <54.54%> (+9.13%)`	⬆️
...ofa/runtime/spring/bean/SofaBeanNameGenerator.java	`64.28% <64.28%> (ø)`
...e/spring/ReferenceAnnotationBeanPostProcessor.java	`67.64% <71.42%> (ø)`
...untime/spring/ServiceBeanFactoryPostProcessor.java	`76.72% <76.72%> (ø)`
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0197fd0...abaec33. Read the comment docs.

straybirdzls · 2018-11-25T10:17:17Z

@QilongZhang There is a huge decline on the code cov, please keep us noticed when it get resolved.

QilongZhang · 2018-11-26T08:56:10Z

To support to this feature, it would produce an incompatible point. In previous version， publishing multi sofa service with same interface type and unique-id would only log warning message. However, now it would lead a fatal exception if spring bean override strategy is not configured as TRUE.

QilongZhang · 2018-11-27T03:18:12Z

To support to this feature, it would produce an incompatible point. In previous version， publishing multi sofa service with same interface type and unique-id would only log warning message. However, now it would lead a fatal exception if spring bean override strategy is not configured as TRUE.

After some discussion, we decide to fix this incompatible point and log some error message to notice users

2018-11-27 11:09:37,351 ERROR main                             - SofaService was already registered: ServiceFactoryBean#com.alipay.sofa.runtime.beans.service.SampleService

caojie09 · 2018-11-27T04:20:45Z

...-sofa-boot-starter/src/main/java/com/alipay/sofa/isle/loader/DynamicSpringContextLoader.java

        GenericApplicationContext ctx = sofaModuleProperties.isPublishEventToParent() ? new GenericApplicationContext(
            beanFactory) : new SofaModuleApplicationContext(beanFactory);
+        SofaRuntimeApplicationListener.initApplicationContext(ctx);


这里直接调用 sofa-runtime 的方法是不是有点奇怪，isle 不应该强耦合 sofa-runtime 吧？在我的理解，如果 sofa-runtime 需要提供一个钩子供 isle 回调，那么其他 starter 是不是也可能有这个需求，是不是能做成更通用的方案呢？

@caojie09 SOFAIsle 和 sofa-runtime 一直是强耦合的. 这里的编码也不是很友好，考虑换一种方式，采用类似 SofaModuleBeanFactoryPostProcessor 的白名单形式也行。

@caojie09 @QilongZhang As discussed offline, I prefer that we should add listener on isle(and mvc) to make the code more flexible.

straybirdzls · 2018-11-28T10:12:48Z

...starter/src/main/java/com/alipay/sofa/runtime/spring/ServiceAnnotationBeanPostProcessor.java

 * @author xuanbei 18/5/9
 */
-public class ServiceAnnotationBeanPostProcessor implements BeanPostProcessor, Ordered,
-                                               ApplicationContextAware {
+public class ServiceAnnotationBeanPostProcessor implements BeanPostProcessor, Ordered {


Should we rename this class to make it more clear?

ok, rename it to ReferenceAnnotationBeanPostProcessor

straybirdzls · 2018-11-28T12:21:13Z

...fa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/bean/SofaBeanNameGenerator.java

+        if (StringUtils.isEmpty(uniqueId)) {
+            return SERVICE_BEAN_NAME_PREFIX + interfaceName;
+        }
+        return SERVICE_BEAN_NAME_PREFIX + interfaceName + ":" + uniqueId;


Duplicate logics here, should directly call following generateSofaServiceBeanName

not actually, parameter type is different

straybirdzls · 2018-11-28T12:51:06Z

...ot-starter/src/main/java/com/alipay/sofa/runtime/spring/ServiceBeanFactoryPostProcessor.java

+                                                   SofaReference sofaReference,
+                                                   Class<?> parameterType,
+                                                   ConfigurableListableBeanFactory beanFactory) {
+        Assert.isTrue("jvm".equals(sofaReference.binding().bindingType()),


Use JvmBinding.JVM_BINDING_TYPE.getType() here instead.

And why only support "jvm" here？

i'm not clear whether it is suitable to support RPC, maybe it would be covered according to actually demand.

caojie09 · 2018-11-29T03:09:18Z

...ot-starter/src/main/java/com/alipay/sofa/runtime/spring/ServiceBeanFactoryPostProcessor.java

+
+/**
+ * @author qilong.zql
+ * @since 2.3.0


since 2.3.0 ？

caojie09 · 2018-11-29T04:00:54Z

...ot-starter/src/main/java/com/alipay/sofa/runtime/spring/ServiceBeanFactoryPostProcessor.java

+            returnType = ClassUtils.forName(methodMetadata.getReturnTypeName(), null);
+            declaringClass = ClassUtils.forName(methodMetadata.getDeclaringClassName(), null);
+            for (Method m : declaringClass.getDeclaredMethods()) {
+                if (!m.getName().equals(beanId)) {


when use @Bean("customBeanName"), beadId not equals methodName.

QilongZhang added 3 commits November 23, 2018 15:43

stash commit

6a82111

Merge branch 'master' into support_issue_277

086acbd

change way to publish sofa service and refactor related code

57659b5

QilongZhang requested review from caojie09, glmapper and straybirdzls November 24, 2018 11:46

QilongZhang added 2 commits November 26, 2018 10:51

fix some problem

7c489a2

support sofa reference on parameter

9a6f33f

QilongZhang added 2 commits November 26, 2018 20:16

fix something

4cb0520

fix test case

5f4fb1f

add test case

33fbfba

caojie09 reviewed Nov 27, 2018

View reviewed changes

straybirdzls reviewed Nov 28, 2018

View reviewed changes

caojie09 reviewed Nov 29, 2018

View reviewed changes

caojie09 approved these changes Nov 29, 2018

View reviewed changes

fix as review

9dfeeed

glmapper approved these changes Nov 29, 2018

View reviewed changes

fix as review

63624ee

straybirdzls approved these changes Nov 29, 2018

View reviewed changes

code format

abaec33

straybirdzls merged commit 50a95ec into sofastack:master Nov 29, 2018

ujjboy added this to the 3.1.0 milestone Nov 30, 2018

QilongZhang deleted the support_issue_277 branch December 26, 2018 14:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support @SofaService to annotated on method and refactor related code. #288

Support @SofaService to annotated on method and refactor related code. #288

QilongZhang commented Nov 24, 2018 •

edited

Loading

codecov bot commented Nov 24, 2018 •

edited

Loading

straybirdzls commented Nov 25, 2018

QilongZhang commented Nov 26, 2018

QilongZhang commented Nov 27, 2018

caojie09 Nov 27, 2018

QilongZhang Nov 27, 2018

straybirdzls Nov 28, 2018 •

edited

Loading

straybirdzls Nov 28, 2018

QilongZhang Nov 29, 2018 •

edited

Loading

straybirdzls Nov 28, 2018 •

edited

Loading

QilongZhang Nov 29, 2018

straybirdzls Nov 28, 2018

straybirdzls Nov 28, 2018

QilongZhang Nov 29, 2018

caojie09 Nov 29, 2018

QilongZhang Nov 29, 2018

caojie09 Nov 29, 2018

QilongZhang Nov 29, 2018

Support @SofaService to annotated on method and refactor related code. #288

Support @SofaService to annotated on method and refactor related code. #288

Conversation

QilongZhang commented Nov 24, 2018 • edited Loading

codecov bot commented Nov 24, 2018 • edited Loading

Codecov Report

straybirdzls commented Nov 25, 2018

QilongZhang commented Nov 26, 2018

QilongZhang commented Nov 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

straybirdzls Nov 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

QilongZhang Nov 29, 2018 • edited Loading

Choose a reason for hiding this comment

straybirdzls Nov 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

QilongZhang commented Nov 24, 2018 •

edited

Loading

codecov bot commented Nov 24, 2018 •

edited

Loading

straybirdzls Nov 28, 2018 •

edited

Loading

QilongZhang Nov 29, 2018 •

edited

Loading

straybirdzls Nov 28, 2018 •

edited

Loading