Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatible with spring cloud #307

Merged
merged 2 commits into from
Dec 26, 2018
Merged

Fix compatible with spring cloud #307

merged 2 commits into from
Dec 26, 2018

Conversation

QilongZhang
Copy link
Contributor

@codecov
Copy link

codecov bot commented Dec 24, 2018 •
edited
Loading

Codecov Report

Merging #307 into master will increase coverage by 0.36%.
The diff coverage is 98.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   62.45%   62.82%   +0.36%     
==========================================
  Files          77       76       -1     
  Lines        1979     1977       -2     
  Branches      231      231              
==========================================
+ Hits         1236     1242       +6     
+ Misses        579      576       -3     
+ Partials      164      159       -5
Impacted Files Coverage Δ
...itializer/SofaRuntimeSpringContextInitializer.java 98.27% <98.03%> (+23.27%) ⬆️
.../sofa/infra/listener/SofaBootstrapRunListener.java 88.67% <0%> (+1.88%) ⬆️
.../sofa/runtime/spi/component/AbstractComponent.java 45.65% <0%> (+2.17%) ⬆️
...a/runtime/component/impl/ComponentManagerImpl.java 67.81% <0%> (+2.29%) ⬆️
...infra/log/space/SofaBootLogSpaceIsolationInit.java 66.66% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d946af1...892c195. Read the comment docs.

@QilongZhang QilongZhang added this to the 3.1.1 milestone Dec 24, 2018
@QilongZhang QilongZhang added the bug Something isn't working label Dec 24, 2018
ujjboy
ujjboy requested changes Dec 25, 2018
View reviewed changes
...ain/java/com/alipay/sofa/runtime/spring/initializer/SofaRuntimeSpringContextInitializer.java
private static SofaRuntimeContext sofaRuntimeContext;
private static AtomicBoolean isInitiated = new AtomicBoolean(false);

public static void initApplicationContext(ConfigurableApplicationContext applicationContext) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this class and its method change to not static?

Copy link
Contributor Author

@QilongZhang QilongZhang Dec 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to remove the modifier of static. but it can't.

ujjboy
ujjboy approved these changes Dec 26, 2018
View reviewed changes
Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@glmapper
Copy link
Contributor

+1

@QilongZhang QilongZhang deleted the fix_297 branch December 26, 2018 14:32
@QilongZhang QilongZhang restored the fix_297 branch December 26, 2018 14:35
@QilongZhang QilongZhang reopened this Dec 26, 2018
@straybirdzls straybirdzls merged commit c4627ba into sofastack:master Dec 26, 2018
@straybirdzls straybirdzls mentioned this pull request Dec 26, 2018
Merged
@QilongZhang QilongZhang changed the title Fix compatible with spring boot Fix compatible with spring cloud Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glmapper glmapper glmapper approved these changes

@straybirdzls straybirdzls straybirdzls approved these changes

@ujjboy ujjboy ujjboy approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@QilongZhang @glmapper @ujjboy @straybirdzls