Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support async init #337

Merged
merged 8 commits into from
Jan 15, 2019
Merged

support async init #337

merged 8 commits into from
Jan 15, 2019

Conversation

QilongZhang
Copy link
Contributor

@QilongZhang QilongZhang added this to the 2.6.0 milestone Jan 12, 2019
@QilongZhang QilongZhang added the enhancement New feature or request label Jan 12, 2019
@codecov
Copy link

codecov bot commented Jan 14, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (2.x@4c2b0f6). Click here to learn what that means.
The diff coverage is 76.68%.

Impacted file tree graph

@@          Coverage Diff           @@
##             2.x     #337   +/-   ##
======================================
  Coverage       ?   65.38%           
======================================
  Files          ?       81           
  Lines          ?     2233           
  Branches       ?      285           
======================================
  Hits           ?     1460           
  Misses         ?      589           
  Partials       ?      184
Impacted Files Coverage Δ
...ing/config/SofaRuntimeConfigurationProperties.java 100% <ø> (ø)
...ofa/infra/constants/CommonMiddlewareConstants.java 0% <ø> (ø)
...ng/configuration/SofaRuntimeAutoConfiguration.java 84.61% <100%> (ø)
...pring/parser/AsyncInitBeanDefinitionDecorator.java 66.66% <66.66%> (ø)
...sofa/runtime/spring/async/AsyncInitBeanHolder.java 69.23% <69.23%> (ø)
...ng/namespace/handler/SofaBootNamespaceHandler.java 81.25% <75%> (ø)
...y/sofa/runtime/spring/async/AsyncTaskExecutor.java 76.92% <76.92%> (ø)
...m/alipay/sofa/runtime/util/NamedThreadFactory.java 80% <80%> (ø)
...fa/runtime/spring/AsyncProxyBeanPostProcessor.java 80.35% <80.35%> (ø)
...ntime/spring/async/AsyncTaskExecutionListener.java 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c2b0f6...e433127. Read the comment docs.

straybirdzls
straybirdzls reviewed Jan 15, 2019
View reviewed changes
...ime-sofa-boot-starter/src/test/java/com/alipay/sofa/runtime/integration/IntegrationTest.java Outdated
@@ -16,6 +16,7 @@
*/
package com.alipay.sofa.runtime.integration;

import com.alipay.sofa.runtime.beans.TimeWasteBean;
import org.junit.Assert;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this unused line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

glmapper
glmapper approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caojie09 caojie09 merged commit 2309d64 into sofastack:2.x Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caojie09 caojie09 caojie09 approved these changes

@glmapper glmapper glmapper approved these changes

@straybirdzls straybirdzls straybirdzls approved these changes

@ujjboy ujjboy Awaiting requested review from ujjboy

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@QilongZhang @straybirdzls @glmapper @caojie09