Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/optimize auto configuration rpc #526

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Chore/optimize auto configuration rpc #526

merged 2 commits into from
Nov 18, 2019

Conversation

leizhiyuan
Copy link
Contributor

optime sofa rpc autoconfiguration

@codecov-io
Copy link

Codecov Report

Merging #526 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #526      +/-   ##
============================================
- Coverage     66.53%   66.49%   -0.04%     
  Complexity       91       91              
============================================
  Files           256      256              
  Lines          7521     7524       +3     
  Branches       1081     1081              
============================================
- Hits           5004     5003       -1     
- Misses         1895     1901       +6     
+ Partials        622      620       -2
Impacted Files Coverage Δ Complexity Δ
...ot/autoconfigure/rpc/SofaRpcAutoConfiguration.java 80% <ø> (-12%) 0 <0> (ø)
...y/sofa/rpc/boot/runtime/param/RpcBindingParam.java 46.15% <0%> (-0.99%) 0 <0> (ø)
...m/alipay/sofa/isle/stage/ModuleLogOutputStage.java 88.57% <0%> (+1.9%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f768bd...a56d130. Read the comment docs.

Copy link
Contributor

@caojie09 caojie09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caojie09 caojie09 merged commit a3d37e1 into sofastack:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants