Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/rpc.tests #703

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Fix/rpc.tests #703

merged 3 commits into from
Sep 8, 2020

Conversation

alaneuler
Copy link
Contributor

No description provided.

@alaneuler alaneuler added this to the 3.4.4 milestone Sep 8, 2020
@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes size/M labels Sep 8, 2020
Copy link
Member

@elseifer elseifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #703 into master will increase coverage by 16.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #703       +/-   ##
=============================================
+ Coverage     52.15%   68.15%   +16.00%     
  Complexity       82       82               
=============================================
  Files           295      295               
  Lines          8304     8307        +3     
  Branches       1156     1156               
=============================================
+ Hits           4331     5662     +1331     
+ Misses         3511     1973     -1538     
- Partials        462      672      +210     
Impacted Files Coverage Δ Complexity Δ
...lipay/sofa/healthcheck/ReadinessCheckListener.java 68.23% <100.00%> (+1.16%) 0.00 <0.00> (ø)
...n/java/com/alipay/sofa/runtime/log/SofaLogger.java 28.78% <0.00%> (+1.51%) 0.00% <0.00%> (ø%)
...ime/component/impl/StandardSofaRuntimeManager.java 81.13% <0.00%> (+1.88%) 0.00% <0.00%> (ø%)
...lipay/sofa/rpc/boot/common/NetworkAddressUtil.java 50.00% <0.00%> (+2.43%) 0.00% <0.00%> (ø%)
...fa/runtime/service/component/ServiceComponent.java 51.33% <0.00%> (+2.66%) 0.00% <0.00%> (ø%)
...a/runtime/invoke/DynamicJvmServiceProxyFinder.java 53.57% <0.00%> (+2.85%) 0.00% <0.00%> (ø%)
.../sofa/healthcheck/impl/ComponentHealthChecker.java 96.66% <0.00%> (+3.33%) 0.00% <0.00%> (ø%)
...m/alipay/sofa/isle/stage/ModuleLogOutputStage.java 88.57% <0.00%> (+3.80%) 0.00% <0.00%> (ø%)
...com/alipay/sofa/runtime/SofaRuntimeProperties.java 80.00% <0.00%> (+6.66%) 0.00% <0.00%> (ø%)
...ofa/runtime/service/binding/JvmBindingAdapter.java 68.46% <0.00%> (+8.10%) 0.00% <0.00%> (ø%)
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f58f2ef...2cd304a. Read the comment docs.

@alaneuler alaneuler merged commit 3f145ae into sofastack:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants