Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor using of sofa-common-tools and support for console logging #760

Merged
merged 15 commits into from
Nov 9, 2020
Merged

Refactor using of sofa-common-tools and support for console logging #760

merged 15 commits into from
Nov 9, 2020

Conversation

alaneuler
Copy link
Contributor

@alaneuler alaneuler commented Nov 8, 2020 •
edited
Loading

fix: #759

HzjNeverStop
HzjNeverStop approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alaneuler alaneuler merged commit 3464221 into sofastack:master Nov 9, 2020
@alaneuler alaneuler added this to the 3.4.6 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HzjNeverStop HzjNeverStop HzjNeverStop approved these changes

Assignees
No one assigned
Labels
cla:yes size/XXL
Projects
None yet
Milestone
3.4.6
Development

Successfully merging this pull request may close these issues.

ReInitializer of log is logically incorrect
2 participants
@alaneuler @HzjNeverStop