Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension component fail insulator config, default to no #763

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

alaneuler
Copy link
Contributor

No description provided.

Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Nov 12, 2020

Codecov Report

Merging #763 (34be4c1) into master (d909a10) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #763      +/-   ##
============================================
- Coverage     70.77%   70.76%   -0.01%     
  Complexity       27       27              
============================================
  Files           290      290              
  Lines          8167     8178      +11     
  Branches       1143     1145       +2     
============================================
+ Hits           5780     5787       +7     
- Misses         1717     1720       +3     
- Partials        670      671       +1     
Impacted Files Coverage Δ Complexity Δ
...sofa/runtime/ext/component/ExtensionComponent.java 56.14% <0.00%> (-3.12%) 0.00 <0.00> (ø)
...com/alipay/sofa/runtime/SofaRuntimeProperties.java 80.00% <90.00%> (ø) 0.00 <0.00> (ø)
.../configure/SofaRuntimeConfigurationProperties.java 95.00% <100.00%> (+0.88%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d909a10...34be4c1. Read the comment docs.

@alaneuler alaneuler merged commit 9c7aa3b into master Nov 12, 2020
@alaneuler alaneuler added this to the 3.4.6 milestone Nov 17, 2020
@HzjNeverStop HzjNeverStop deleted the chore/extension.insulator branch December 16, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants