Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for automatically console logging when local developing #772

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Support for automatically console logging when local developing #772

merged 1 commit into from
Dec 14, 2020

Conversation

alaneuler
Copy link
Contributor

No description provided.

@sofastack-bot sofastack-bot bot added cla:yes question Further information is requested size/M labels Dec 14, 2020
@codecov-io
Copy link

Codecov Report

Merging #772 (9320184) into master (cdbf89d) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #772      +/-   ##
============================================
- Coverage     70.79%   70.78%   -0.01%     
- Complexity       29       32       +3     
============================================
  Files           291      292       +1     
  Lines          8228     8240      +12     
  Branches       1148     1148              
============================================
+ Hits           5825     5833       +8     
- Misses         1731     1736       +5     
+ Partials        672      671       -1     
Impacted Files Coverage Δ Complexity Δ
...ntime/spring/async/AsyncTaskExecutionListener.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/com/alipay/sofa/boot/logging/LocalEnvUtil.java 50.00% <50.00%> (ø) 2.00 <2.00> (?)
.../boot/logging/LogEnvironmentPreparingListener.java 90.90% <50.00%> (-9.10%) 9.00 <1.00> (+1.00) ⬇️
...m/alipay/sofa/isle/stage/ModuleLogOutputStage.java 94.93% <0.00%> (+2.53%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdbf89d...9320184. Read the comment docs.

Copy link
Contributor

@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alaneuler alaneuler merged commit 6944d42 into sofastack:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes question Further information is requested size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants