refactor startup endpoint #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 5, 2021 14:26
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
============================================
+ Coverage 70.69% 71.28% +0.58%
Complexity 32 32
============================================
Files 294 297 +3
Lines 8254 8374 +120
Branches 1149 1160 +11
============================================
+ Hits 5835 5969 +134
+ Misses 1748 1735 -13
+ Partials 671 670 -1
Continue to review full report at Codecov.
|
alaneuler
reviewed
Jan 7, 2021
...sle-sofa-boot/src/main/java/com/alipay/sofa/isle/spring/factory/BeanLoadCostBeanFactory.java
Outdated
Show resolved
Hide resolved
alaneuler
reviewed
Jan 7, 2021
| CommonStartupCost commonStartupCost = new CommonStartupCost(); | ||
| commonStartupCost.setName(name.getRawName()); | ||
| commonStartupCost.setBeginTime(System.currentTimeMillis()); | ||
| StageStat stageStat = new StageStat(); |
There was a problem hiding this comment.
这是给每个 sofa 组件都算一下时间？
这里是之前的逻辑，应该删掉的
alaneuler
reviewed
Jan 7, 2021
| */ | ||
| public interface BeanStatExtension { | ||
| void customBeanStat(String beanName, RootBeanDefinition mbd, Object[] args, BeanStat bs); | ||
| } |
There was a problem hiding this comment.
no new line
done
|
|
||
| if (beanStatExtension != null) { | ||
| beanStatExtension.customBeanStat(beanName, mbd, args, bs); | ||
| } |
There was a problem hiding this comment.
扩展点的展示结果是什么样的？
扩展点用于定制bs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.