-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracer autoconfigure. (#847) #875
Conversation
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
============================================
- Coverage 11.38% 11.25% -0.13%
Complexity 41 41
============================================
Files 312 325 +13
Lines 9207 9310 +103
Branches 1270 1275 +5
============================================
Hits 1048 1048
- Misses 8001 8104 +103
Partials 158 158
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mongodb 和 rocketmq 的基础 processor 可以提供一下测试用例吗?
...src/main/java/com/alipay/sofa/boot/autoconfigure/tracer/SofaTracerRabbitMqConfiguration.java
Outdated
Show resolved
Hide resolved
...java/com/alipay/sofa/tracer/boot/rabbitmq/processor/SofaTracerRabbitMqBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/alipay/sofa/boot/autoconfigure/tracer/SofaTracerRabbitMqConfiguration.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/com/alipay/sofa/boot/autoconfigure/tracer/SofaTracerRedisConfiguration.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/com/alipay/sofa/boot/autoconfigure/tracer/SofaTracerRedisConfiguration.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/alipay/sofa/boot/autoconfigure/tracer/SpringMessageAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...ava/com/alipay/sofa/tracer/boot/message/processor/StreamRocketMQTracerBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/alipay/sofa/boot/autoconfigure/tracer/SofaTracerRocketMqConfiguration.java
Outdated
Show resolved
Hide resolved
@it-linnan 还有一个问题,原先 tracer 代码中的 @author 标签不对(后边没有冒号的),也辛苦改一下。 review 有点慢,还请见谅~ |
@it-linnan 感谢贡献代码~ mongodb 和 rocketmq 的基础 processor 可以提供一下测试用例吗? |
好的,我写一下测试用例 |
@alaneuler 测试用例已提交,麻烦review下,辛苦~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
为 SOFATracer 中的 plugin 增加 SOFABoot auto-configuration
fix #847
以下plugin的autoconfigure,是从SOFATracer 3.1.0版本的starter中抽取了相关代码,同步过来的。
MongoDB plugin 的autoconfigure
前提:SOFATracer基于MongoDB 3.8.2版本的驱动实现,而当前版本SOFABoot依赖MongoDB 4.0.5版本驱动。因此,需基于当前版本驱动的
MongoClient
和MongoAutoConfiguration
实现自动配置。实现思路:注册自定义
MongoClientSettingsBuilderCustomizer
bean,向MongoDB client的配置类中增加SofaTracerCommandListener。RocketMQ plugin 的autoconfigure