Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize extension component health report #879

Merged
merged 4 commits into from
Nov 8, 2021
Merged

optimize extension component health report #879

merged 4 commits into from
Nov 8, 2021

Conversation

HzjNeverStop
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #879 (f8aca4a) into master (b3770f2) will increase coverage by 0.14%.
The diff coverage is 31.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #879      +/-   ##
============================================
+ Coverage     71.15%   71.29%   +0.14%     
  Complexity       36       36              
============================================
  Files           303      303              
  Lines          8601     8616      +15     
  Branches       1195     1198       +3     
============================================
+ Hits           6120     6143      +23     
+ Misses         1794     1785       -9     
- Partials        687      688       +1     
Impacted Files Coverage Δ
...sofa/runtime/ext/component/ExtensionComponent.java 50.64% <31.25%> (-2.58%) ⬇️
.../sofa/runtime/spi/component/AbstractComponent.java 82.08% <0.00%> (+1.49%) ⬆️
...com/alipay/sofa/runtime/SofaRuntimeProperties.java 81.25% <0.00%> (+2.08%) ⬆️
...m/alipay/sofa/isle/stage/ModuleLogOutputStage.java 94.93% <0.00%> (+2.53%) ⬆️
...runtime/ext/component/ExtensionPointComponent.java 90.90% <0.00%> (+39.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3770f2...f8aca4a. Read the comment docs.

//表示对应的 ExtensionPoint 未注册
if (!isResolved()) {
healthResult.setHealthy(false);
healthResult.setHealthReport("Can not found corresponding ExtensionPoint: "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can not find...

@sofastack-bot sofastack-bot bot added size/L and removed size/M labels Oct 25, 2021
@sofastack-bot sofastack-bot bot added size/M and removed size/L labels Oct 25, 2021
Copy link
Contributor

@alaneuler alaneuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit f65941f into sofastack:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants