Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support showDetail=false in readiness endpoint #957

Merged
merged 1 commit into from
May 16, 2022

Conversation

HzjNeverStop
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #957 (480285c) into master (63572c2) will increase coverage by 0.09%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #957      +/-   ##
============================================
+ Coverage     11.26%   11.36%   +0.09%     
  Complexity       39       39              
============================================
  Files           311      311              
  Lines          9045     9048       +3     
  Branches       1246     1247       +1     
============================================
+ Hits           1019     1028       +9     
+ Misses         7883     7870      -13     
- Partials        143      150       +7     
Impacted Files Coverage Δ
...actuator/health/ReadinessEndpointWebExtension.java 0.00% <0.00%> (ø)
...oot/actuator/health/SofaBootReadinessEndpoint.java 0.00% <0.00%> (ø)
.../sofa/runtime/spi/component/AbstractComponent.java 32.85% <0.00%> (+12.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63572c2...480285c. Read the comment docs.

Copy link
Member

@antfin-oss antfin-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujjboy ujjboy merged commit b12b09a into sofastack:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants