-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Compatible with Protobuf empty object. #1376
base: master
Are you sure you want to change the base?
Conversation
Hi @imangry, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
remoting/remoting-bolt/src/main/java/com/alipay/sofa/rpc/codec/bolt/SofaRpcSerialization.java
Show resolved
Hide resolved
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1376 +/- ##
==========================================
Coverage 72.01% 72.02%
- Complexity 784 795 +11
==========================================
Files 416 422 +6
Lines 17661 17813 +152
Branches 2752 2768 +16
==========================================
+ Hits 12719 12830 +111
- Misses 3538 3574 +36
- Partials 1404 1409 +5 ☔ View full report in Codecov by Sentry. |
Motivation:
When sending or returning a Protobuf empty object with a content length of 0,just like
PagePB.Response.getDefaultInstance()
, the client or server will report an error. This modification will be compatible with this situation.