This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
delete modules in batches #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charlie17Li
force-pushed
the
delete_in_batches
branch
2 times, most recently
from
cb3096d
to
b8c6588
Compare
Charlie17Li
force-pushed
the
delete_in_batches
branch
3 times, most recently
from
23365e6
to
928a00b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
============================================
- Coverage 82.26% 73.72% -8.54%
============================================
Files 38 17 -21
Lines 919 1610 +691
Branches 78 0 -78
============================================
+ Hits 756 1187 +431
- Misses 116 325 +209
- Partials 47 98 +51 ☔ View full report in Codecov by Sentry. |
gold300jin
reviewed
Nov 6, 2023
module-controller/internal/controller/moduledeployment_controller.go
Outdated
Show resolved
Hide resolved
gold300jin
reviewed
Nov 6, 2023
Charlie17Li
force-pushed
the
delete_in_batches
branch
from
4b43744
to
75d9e33
Compare
Charlie17Li
force-pushed
the
delete_in_batches
branch
from
1a0bf17
to
981f716
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
当前 Module Deployment 在创建时支持分批发布，期望在删除时也支持分批删除
Modification
修改 module-deployment-controller
Result
支持分批删除