Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

添加 event新类型,添加 计算 基座 Pod上 最大/最小/平均 已被调度模块实例个数 修复ModuleDeployment单测 #208

Merged
merged 7 commits into from
Nov 15, 2023

Conversation

liu-657667
Copy link
Collaborator

  1. 背景
    当前无法直观的查询到基座上部署的模块实例个数,可以给 K8S Pod、Deployment 或 ReplicaSet 上加一些 label,让用户能直观的看到基座上部署的模块实例个数

  2. 当前影响
    无法直观的查询到基座上部署的模块实例个数

  3. 解决方案
    每次扩缩容完毕后,获取全量pod计算 基座 Pod上 最大/最小/平均 已被调度模块实例个数

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (ca9a253) 76.00% compared to head (aab79e5) 77.24%.
Report is 224 commits behind head on master.

Files Patch % Lines
...ndler/modulereplicaset_replicas_changed_handler.go 70.00% 14 Missing and 7 partials ⚠️
module-controller/internal/utils/test_utils.go 89.41% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   76.00%   77.24%   +1.24%     
==========================================
  Files          15       17       +2     
  Lines        1421     1582     +161     
==========================================
+ Hits         1080     1222     +142     
- Misses        243      253      +10     
- Partials       98      107       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lvjing2
Copy link
Collaborator

lvjing2 commented Oct 25, 2023

通过模块实例聚合出来,或者调研arklet接口呢?

@liu-657667
Copy link
Collaborator Author

通过模块实例聚合出来,或者调研arklet接口呢?

ok

Copy link
Collaborator

@gold300jin gold300jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gold300jin gold300jin merged commit 1fd9d3a into master Nov 15, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants