This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
使用usebeta分组分组数+1 #434
Merged
使用usebeta分组分组数+1 #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #434 +/- ##
==========================================
+ Coverage 74.21% 74.25% +0.04%
==========================================
Files 17 17
Lines 1617 1620 +3
==========================================
+ Hits 1200 1203 +3
- Misses 321 324 +3
+ Partials 96 93 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
当同时使用 useBeta 和 batchCount，处理好兼容性。使用useBeta且ModuleDeployment的replicas数量-1 > 1时分组数增加一组
Modification
当同时使用 useBeta 和 batchCount 时且ModuleDeployment的replicas数量-1 > 1时分组数增加一组
Result
#392