Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add truncate for names in sidebar pane #484

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marcincodes
Copy link
Collaborator

@marcincodes marcincodes commented Sep 30, 2023

Describe your changes

Truncate names that are overflowed

Screenshot 2023-09-30 at 16 56 58

Issue link

#446

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2023

⚠️ No Changeset found

Latest commit: e0401fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 30, 2023

@marcincodes is attempting to deploy a commit to the sofn Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@psugihara psugihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mailing-dynamic-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 8:45pm
web-emails ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 8:45pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
mailing-web ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2023 8:45pm

@psugihara
Copy link
Collaborator

I think there's a real test failure on this one, I re-ran a couple times.

@marcincodes
Copy link
Collaborator Author

Seems like I added a div and accessibility tool catch that this div is not accessible:

expected '<div.truncate>' to have attribute 'aria-selected'

I will fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants